[Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 67 matching lines @@
   virtual void RenderThreadStarted() {}
 
   // Notifies that a new RenderFrame has been created. Note that at this point,
   // render_frame->GetWebFrame()->parent() is always NULL. This will change once
   // the frame tree moves from Blink to content.
   virtual void RenderFrameCreated(RenderFrame* render_frame) {}
 
   // Notifies that a new RenderView has been created.
   virtual void RenderViewCreated(RenderView* render_view) {}
 
+  virtual void ServiceWorkerCreated() {}

[Devlin, 2015/07/30 21:31:08]

Are these used?

[annekao, 2015/07/30 22:54:18]

Removed.

+  virtual void ServiceWorkerContextInitialized() {}
+  virtual void ServiceWorkerDestroyed() {}
+
   // Returns the bitmap to show when a plugin crashed, or NULL for none.
   virtual SkBitmap* GetSadPluginBitmap();
 
   // Returns the bitmap to show when a <webview> guest has crashed, or NULL for
   // none.
   virtual SkBitmap* GetSadWebViewBitmap();
 
   // Allows the embedder to create a plugin placeholder instead of a plugin.
   // Called before OverrideCreatePlugin. May return null to decline to provide
   // a plugin placeholder.
@@ skipping 192 matching lines @@
 
   // Allows an embedder to provide a blink::WebAppBannerClient.
   virtual scoped_ptr<blink::WebAppBannerClient> CreateAppBannerClient(
       RenderFrame* render_frame);
 
   // Gives the embedder a chance to add properties to the context menu.
   // Currently only called when the context menu is for an image.
   virtual void AddImageContextMenuProperties(
       const blink::WebURLResponse& response,
       std::map<std::string, std::string>* properties) {}
+
+  virtual void DidInitializeWorkerContext(v8::Local<v8::Context> context,

[Devlin, 2015/07/30 21:31:08]

Comment this method.
Also, I'd rename this to DidInitializeWorkerContextOnWorkerThread(), so that
it's apparent that it's on a different thread.

[annekao, 2015/07/30 22:54:18]

Done.

[Devlin, 2015/07/30 22:58:51]

The method still has no comment...

[annekao, 2015/07/30 23:57:39]

Oops, somehow missed the first line. Done.

+                                          const GURL& url){};
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_