Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256313004: Use goma only if --gomadir is set. (Closed)

Created:
5 years, 4 months ago by Yoshisato Yanagisawa
Modified:
5 years, 4 months ago
Reviewers:
sunnyps, bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -37 lines) Patch
M build/build_nexe.py View 2 chunks +12 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yoshisato Yanagisawa
Hi, As suggested in https://code.google.com/p/chromium/issues/detail?id=516552, let me enable goma only if --gomadir is set. i.e. ...
5 years, 4 months ago (2015-08-04 10:03:42 UTC) #2
bradn
lgtm
5 years, 4 months ago (2015-08-04 11:54:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256313004/1
5 years, 4 months ago (2015-08-05 01:39:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 04:38:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/a8bd1a6d0...

Powered by Google App Engine
This is Rietveld 408576698