Use goma only if --gomadir is set.

build/build_nexe.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """NEXE building script
 
 This module will take a set of source files, include paths, library paths, and
 additional arguments, and use them to build.
 """
@@ skipping 389 matching lines @@
     if path.startswith('/cygdrive/'):
       path = os.path.normpath(
           path[len(cygdrive)] + ':' + path[len(cygdrive)+1:])
     elif path.startswith('/libexec/'):
       path = os.path.normpath(os.path.join(self.toolchain, path[1:]))
     return path
 
   def GetGomaConfig(self, gomadir, arch, toolname):
     """Returns a goma config dictionary if goma is available or {}."""
 
+    # Goma is enabled only if gomadir is given.
+    # We do not use gomacc in GOMA_DIR or PATH anymore.
+    if not gomadir:
+      return {}
+
     # Start goma support from os/arch/toolname that have been tested.
     # Set NO_NACL_GOMA=true to force to avoid using goma.
     default_no_nacl_goma = True if pynacl.platform.IsWindows() else False
     if (arch not in ['x86-32', 'x86-64', 'pnacl']
         or toolname not in ['newlib', 'glibc']
         or IsEnvFlagTrue('NO_NACL_GOMA', default=default_no_nacl_goma)
         or IsEnvFlagTrue('GOMA_DISABLED')):
       return {}
 
-    goma_config = {}
     gomacc_base = 'gomacc.exe' if pynacl.platform.IsWindows() else 'gomacc'
-    # Search order of gomacc:
-    # --gomadir command argument -> GOMA_DIR env. -> PATH env.
-    search_path = []
-    # 1. --gomadir in the command argument.
-    if gomadir:
-      search_path.append(gomadir)
-    # 2. Use GOMA_DIR environment variable if exist.
-    goma_dir_env = os.environ.get('GOMA_DIR')
-    if goma_dir_env:
-      search_path.append(goma_dir_env)
-    # 3. Append PATH env.
-    path_env = os.environ.get('PATH')
-    if path_env:
-      search_path.extend(path_env.split(os.path.pathsep))
-
-    for directory in search_path:
-      gomacc = os.path.join(directory, gomacc_base)
-      if os.path.isfile(gomacc):
-        try:
-          port = int(subprocess.Popen(
-              [gomacc, 'port'],
-              stdout=subprocess.PIPE).communicate()[0].strip())
-          status = urllib2.urlopen(
-              'http://127.0.0.1:%d/healthz' % port).read().strip()
-          if status == 'ok':
-            goma_config['gomacc'] = gomacc
-            break
-        except (OSError, ValueError, urllib2.URLError) as e:
-          # Try another gomacc in the search path.
-          self.Log('Strange gomacc %s found, try another one: %s' % (gomacc, e))
-
-    if goma_config:
-      goma_config['burst'] = IsEnvFlagTrue('NACL_GOMA_BURST')
-      default_processes = 100 if pynacl.platform.IsLinux() else 10
-      goma_config['processes'] = GetIntegerEnv('NACL_GOMA_PROCESSES',
-                                               default=default_processes)
+    goma_config = {
+        'gomacc': os.path.join(gomadir, gomacc_base),
+        'burst': IsEnvFlagTrue('NACL_GOMA_BURST'),
+    }
+    default_processes = 100 if pynacl.platform.IsLinux() else 10
+    goma_config['processes'] = GetIntegerEnv('NACL_GOMA_PROCESSES',
+                                             default=default_processes)
     return goma_config
 
   def NeedsRebuild(self, outd, out, src, rebuilt=False):
     if not IsFile(self.toolstamp):
       if rebuilt:
         raise Error('Could not find toolchain stamp file %s.' % self.toolstamp)
       return True
     if not IsFile(self.cmd_file):
       if rebuilt:
         raise Error('Could not find cmd file %s.' % self.cmd_file)
@@ skipping 661 matching lines @@
     if build is not None:
       build.EmitDeferredLog()
     return 1
   except:
     if build is not None:
       build.EmitDeferredLog()
     raise
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))