Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1256203004: AdjustLiveBytes and friends takes a heap object pointer instead of an address. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

AdjustLiveBytes and friends takes a heap object pointer instead of an address. That makes going to the page safe. Addresses can be in arbitrary locations of an object, e.g. in a large object but not on the first 1M page. BUG= Committed: https://crrev.com/8548ea5d1a38412531a71c5a647baf8c1c8b1ea0 Cr-Commit-Position: refs/heads/master@{#29991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/heap/incremental-marking.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-03 17:08:44 UTC) #2
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-03 19:06:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256203004/1
5 years, 4 months ago (2015-08-04 06:33:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 07:02:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 07:03:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8548ea5d1a38412531a71c5a647baf8c1c8b1ea0
Cr-Commit-Position: refs/heads/master@{#29991}

Powered by Google App Engine
This is Rietveld 408576698