src/heap/incremental-marking-inl.h - Issue 1256203004: AdjustLiveBytes and friends takes a heap object pointer instead of an address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking-inl.h

Issue 1256203004: AdjustLiveBytes and friends takes a heap object pointer instead of an address. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking-inl.h

diff --git a/src/heap/incremental-marking-inl.h b/src/heap/incremental-marking-inl.h

index 42b3dcb127da27fc1ebd937912c43580735dd596..d523841a872e36e8247b7dd4d89df0d78260748c 100644

--- a/src/heap/incremental-marking-inl.h

+++ b/src/heap/incremental-marking-inl.h

@@ -85,7 +85,7 @@ void IncrementalMarking::BlackToGreyAndUnshift(HeapObject* obj,

DCHECK(IsMarking());

Marking::BlackToGrey(mark_bit);

int obj_size = obj->Size();

- MemoryChunk::IncrementLiveBytesFromGC(obj->address(), -obj_size);

+ MemoryChunk::IncrementLiveBytesFromGC(obj, -obj_size);

bytes_scanned_ -= obj_size;

int64_t old_bytes_rescanned = bytes_rescanned_;

bytes_rescanned_ = old_bytes_rescanned + obj_size;

« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/mark-compact.h » ('j') | no next file with comments »