Source/modules/serviceworkers/ExtendableEvent.h - Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ExtendableEvent.h

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comment: add/delete headers. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ExtendableEvent.h

diff --git a/Source/modules/serviceworkers/ExtendableEvent.h b/Source/modules/serviceworkers/ExtendableEvent.h

index 585bc85111c35225324508c5775778f413fcca3e..63b0078578bd997b3349757380937ed6a58fe8ee 100644

--- a/Source/modules/serviceworkers/ExtendableEvent.h

+++ b/Source/modules/serviceworkers/ExtendableEvent.h

@@ -31,7 +31,7 @@

#ifndef ExtendableEvent_h

#define ExtendableEvent_h

-#include "bindings/core/v8/ScriptValue.h"

+#include "bindings/core/v8/ScriptPromise.h"

#include "modules/EventModules.h"

#include "modules/ModulesExport.h"

#include "modules/serviceworkers/ExtendableEventInit.h"

@@ -49,7 +49,7 @@ public:

~ExtendableEvent() override;

- void waitUntil(ScriptState*, const ScriptValue&, ExceptionState&);

+ void waitUntil(ScriptState*, ScriptPromise, ExceptionState&);

const AtomicString& interfaceName() const override;

DECLARE_VIRTUAL_TRACE();

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ExtendableEvent.cpp » ('j') | Source/modules/serviceworkers/ExtendableEvent.idl » ('J')