Source/modules/serviceworkers/ExtendableEvent.cpp - Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ExtendableEvent.cpp

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comment: add/delete headers. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.h ('k') | Source/modules/serviceworkers/ExtendableEvent.idl » ('j') | Source/modules/serviceworkers/ExtendableEvent.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ExtendableEvent.cpp

diff --git a/Source/modules/serviceworkers/ExtendableEvent.cpp b/Source/modules/serviceworkers/ExtendableEvent.cpp

index cdf6c06e53cb4455f359433bf38efd076eeda17d..d398fc5753fd11592c407e38444925f32d96d54a 100644

--- a/Source/modules/serviceworkers/ExtendableEvent.cpp

+++ b/Source/modules/serviceworkers/ExtendableEvent.cpp

@@ -55,10 +55,10 @@ ExtendableEvent::~ExtendableEvent()

{

}

-void ExtendableEvent::waitUntil(ScriptState* scriptState, const ScriptValue& value, ExceptionState& exceptionState)

+void ExtendableEvent::waitUntil(ScriptState* scriptState, ScriptPromise scriptPromise, ExceptionState& exceptionState)

{

if (m_observer)

- m_observer->waitUntil(scriptState, value, exceptionState);

+ m_observer->waitUntil(scriptState, scriptPromise, exceptionState);

}

ExtendableEvent::ExtendableEvent()