Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1256103006: Merge to XFA: Kill FX_HFILE (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Kill FX_HFILE (cherry picked from commit c8eeed31f217d99a706b0cbf5e4ce0bcc12beb64) Review URL: https://codereview.chromium.org/1259123008 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/780cee82236d1b3b0f9b01a22424e4b8ec9a6f12

Patch Set 1 #

Patch Set 2 : Deleted too much. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M core/include/fxcrt/fx_stream.h View 2 chunks +0 lines, -15 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, nearly automatic, but I blew the manual part once, so review.
5 years, 4 months ago (2015-07-31 22:18:57 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-31 22:50:22 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-07-31 23:00:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
780cee82236d1b3b0f9b01a22424e4b8ec9a6f12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698