Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1259123008: Kill FX_HFILE (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill FX_HFILE FX_HFILE, and the routines that operate on it, are unused. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c8eeed31f217d99a706b0cbf5e4ce0bcc12beb64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M core/include/fxcrt/fx_stream.h View 2 chunks +0 lines, -15 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, look what I found.
5 years, 4 months ago (2015-07-31 21:52:14 UTC) #2
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-31 21:55:47 UTC) #3
Tom Sepez
5 years, 4 months ago (2015-07-31 22:09:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8eeed31f217d99a706b0cbf5e4ce0bcc12beb64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698