Change var blah_blah -> blahBlah.

Change var blah_blah -> blahBlah.

http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Naming

R=estade@chromium.org
TBR=rdsmith@chromium.org
BUG=none, though I'll probably make one for a presubmit check.
TEST=no regressions, better js style in c/b/resources

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187259

[Evan Stade, 2013-03-07 05:48:09]

rubber stamp lgtm

[commit-bot: I haz the power, 2013-03-07 18:45:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/12560002/29003

[commit-bot: I haz the power, 2013-03-07 18:46:03]

Presubmit check for 12560002-29003 failed and returned exit status 1.

INFO:root:Found 32 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org or dbeam@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/backloader/scripts/background.js:
  line 12: E0220: No docs found for member 'Loader.instance_'
Loader.instance_ = null;
^^^^^^^^^^^^^^^^
  line 15: E0220: No docs found for member 'Loader.getInstance'
Loader.getInstance = function() {
^^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/chromeos/network_menu.js:
  line 7: Use var instead of const.
const StatusConnected = 'connected';
^^^^^
  line 8: Use var instead of const.
const StatusDisconnected = 'disconnected';
^^^^^
  line 9: Use var instead of const.
const StatusConnecting = 'connecting';
^^^^^
  line 10: Use var instead of const.
const StatusError = 'error';
^^^^^
  line 12: Use var instead of const.
const NetworkOther = 'other';
^^^^^
  line 34: E0210: Missing docs for parameter: "index"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "passphrase"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "identity"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "auto_connect"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 131: E0001: Extra space before ":"
  handleConnect_ : function(e) {
                ^
  line 179: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^

Found JavaScript style violations in
chrome/browser/resources/sync_internals/traffic.js:
  line 6: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var trafficToTextButton = document.getElementById('traffic-to-text');
                            ^^^^^^^^^^^^^^^^^^^^^^^
  line 7: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var trafficDump = document.getElementById('traffic-dump');
                    ^^^^^^^^^^^^^^^^^^^^^^^

Presubmit checks took 10.7s to calculate.

[Dan Beam, 2013-03-08 16:35:02]

+rdsmith@ as TBR for simple variable rename

[commit-bot: I haz the power, 2013-03-10 01:25:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/12560002/83001

[commit-bot: I haz the power, 2013-03-10 01:25:46]

Failed to apply patch for
chrome/browser/resources/options/browser_options_startup_page_list.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/resources/options/browser_options_startup_page_list.js
  Hunk #1 FAILED at 241.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/options/browser_options_startup_page_list.js.rej

Patch:      
chrome/browser/resources/options/browser_options_startup_page_list.js
Index: chrome/browser/resources/options/browser_options_startup_page_list.js
diff --git
a/chrome/browser/resources/options/browser_options_startup_page_list.js
b/chrome/browser/resources/options/browser_options_startup_page_list.js
index
1fa9252523164f2466f2980c3c47353439da8900..125c1e5591cd805960784d1ddce2f74eca57bb96
100644
--- a/chrome/browser/resources/options/browser_options_startup_page_list.js
+++ b/chrome/browser/resources/options/browser_options_startup_page_list.js
@@ -241,12 +241,12 @@ cr.define('options.browser_options', function() {
         newIndex += 1;
 
       var selected = this.selectionModel.selectedIndexes;
-      var stringized_selected = [];
+      var stringizedSelected = [];
       for (var j = 0; j < selected.length; j++)
-        stringized_selected.push(String(selected[j]));
+        stringizedSelected.push(String(selected[j]));
 
       chrome.send('dragDropStartupPage',
-          [String(newIndex), stringized_selected]);
+          [String(newIndex), stringizedSelected]);
     },
 
     /**

[commit-bot: I haz the power, 2013-03-10 03:22:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/12560002/88001

[commit-bot: I haz the power, 2013-03-10 03:22:56]

Presubmit check for 12560002-88001 failed and returned exit status 1.

INFO:root:Found 32 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org or dbeam@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/backloader/scripts/background.js:
  line 12: E0220: No docs found for member 'Loader.instance_'
Loader.instance_ = null;
^^^^^^^^^^^^^^^^
  line 15: E0220: No docs found for member 'Loader.getInstance'
Loader.getInstance = function() {
^^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/chromeos/network_menu.js:
  line 7: Use var instead of const.
const StatusConnected = 'connected';
^^^^^
  line 8: Use var instead of const.
const StatusDisconnected = 'disconnected';
^^^^^
  line 9: Use var instead of const.
const StatusConnecting = 'connecting';
^^^^^
  line 10: Use var instead of const.
const StatusError = 'error';
^^^^^
  line 12: Use var instead of const.
const NetworkOther = 'other';
^^^^^
  line 34: E0210: Missing docs for parameter: "index"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "passphrase"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "identity"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 34: E0210: Missing docs for parameter: "auto_connect"
function sendConnect(index, passphrase, identity, auto_connect) {
                                                              ^^
  line 131: E0001: Extra space before ":"
  handleConnect_ : function(e) {
                ^
  line 179: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^

Found JavaScript style violations in
chrome/browser/resources/sync_internals/traffic.js:
  line 6: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var trafficToTextButton = document.getElementById('traffic-to-text');
                            ^^^^^^^^^^^^^^^^^^^^^^^
  line 7: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var trafficDump = document.getElementById('traffic-dump');
                    ^^^^^^^^^^^^^^^^^^^^^^^

Presubmit checks took 9.5s to calculate.

[Dan Beam, 2013-03-11 09:02:15]

Committed patchset #15 manually as r187259 (presubmit successful).

[Randy Smith (Not in Mondays), 2013-03-12 05:02:04]

chrome/browser/download LGTM.