Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/resources/suggestions_internals/suggestions_internals.js

Issue 12560002: Change var blah_blah -> blahBlah. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/profiler/profiler.js ('k') | chrome/browser/resources/sync_internals/traffic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/suggestions_internals/suggestions_internals.js
diff --git a/chrome/browser/resources/suggestions_internals/suggestions_internals.js b/chrome/browser/resources/suggestions_internals/suggestions_internals.js
index 90d0ce8d9762d104507a2c28ade514087bcfa120..35988303db0ea5b6c9ac4df73b8fcbfd7c8409f7 100644
--- a/chrome/browser/resources/suggestions_internals/suggestions_internals.js
+++ b/chrome/browser/resources/suggestions_internals/suggestions_internals.js
@@ -81,10 +81,10 @@ cr.define('suggestionsInternals', function() {
var columns = [];
list.forEach(function(entry) {
for (var column in entry) {
- if (typeof(entry[column]) == 'object') {
+ if (typeof entry[column] == 'object') {
// Expand one level deep
- for (var sub_column in entry[column]) {
- var path = column + '.' + sub_column;
+ for (var subColumn in entry[column]) {
+ var path = column + '.' + subColumn;
if (columns.indexOf(path) < 0)
columns.push(path);
}
@@ -130,10 +130,10 @@ cr.define('suggestionsInternals', function() {
var rank = 1;
list.forEach(function(entry) {
var row = document.createElement('tr');
- columns.forEach(function(column_name) {
+ columns.forEach(function(columnName) {
var column = document.createElement('td');
// Expand the path and find the data if it's there.
- var path = column_name.split('.');
+ var path = columnName.split('.');
var data = entry;
for (var i = 0; i < path.length; ++i) {
if (data && data.hasOwnProperty(path[i]))
@@ -155,15 +155,15 @@ cr.define('suggestionsInternals', function() {
} else {
column.innerText = data;
}
- } else if (column_name == 'rank') {
+ } else if (columnName == 'rank') {
column.innerText = rank++;
- } else if (column_name == 'screenshot') {
+ } else if (columnName == 'screenshot') {
var thumbnailUrl = 'chrome://thumb/' + entry.url;
var img = document.createElement('img');
img.onload = function() { setBooleanColumn(column, true); }
img.onerror = function() { setBooleanColumn(column, false); }
img.src = thumbnailUrl;
- } else if (column_name == 'favicon') {
+ } else if (columnName == 'favicon') {
var faviconUrl = 'chrome://favicon/size/16@1x/' + entry.url;
column.style.backgroundImage = url(faviconUrl);
column.style.backgroundRepeat = 'no-repeat';
« no previous file with comments | « chrome/browser/resources/profiler/profiler.js ('k') | chrome/browser/resources/sync_internals/traffic.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698