Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1255943002: One-time migration of NPAPI Flash to PPAPI Flash. (Closed)

Created:
5 years, 5 months ago by Will Harris
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer, jam
CC:
chromium-reviews, jam, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

One-time migration of NPAPI Flash to PPAPI Flash. Migrate users with PPAPI Flash disabled and NPAPI Flash enabled to PPAPI Flash for M45. Clean up some old migration code that wasn't being used any more. Simplify the system Pepper Flash detection logic. BUG=510114, 454131 TEST=See bug for detailed manual tests. Committed: https://crrev.com/d5e116ae533e10d6528c1a55c4e76f64ce11bd3f Cr-Commit-Position: refs/heads/master@{#340556}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Patch Set 3 : use correct plugin name on OS X #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -127 lines) Patch
M chrome/browser/plugins/plugin_prefs.cc View 1 5 chunks +11 lines, -41 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 3 chunks +7 lines, -32 lines 0 comments Download
M chrome/common/chrome_paths.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 5 chunks +34 lines, -28 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Will Harris
PTAL bauerb -> chrome/browser/plugins/* and plugins_ui.cc jam -> the other content/ changes I might ask ...
5 years, 5 months ago (2015-07-24 19:57:43 UTC) #2
jam
lgtm
5 years, 5 months ago (2015-07-24 20:20:26 UTC) #3
Bernhard Bauer
lgtm https://codereview.chromium.org/1255943002/diff/1/chrome/browser/plugins/plugin_prefs.cc File chrome/browser/plugins/plugin_prefs.cc (right): https://codereview.chromium.org/1255943002/diff/1/chrome/browser/plugins/plugin_prefs.cc#newcode333 chrome/browser/plugins/plugin_prefs.cc:333: // M45. Can you add a TODO to ...
5 years, 4 months ago (2015-07-27 10:08:33 UTC) #4
Will Harris
Thanks for the review. I'm doing a little bit more manual testing on Mac then ...
5 years, 4 months ago (2015-07-27 16:08:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255943002/40001
5 years, 4 months ago (2015-07-27 18:57:51 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-27 20:47:07 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:47:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5e116ae533e10d6528c1a55c4e76f64ce11bd3f
Cr-Commit-Position: refs/heads/master@{#340556}

Powered by Google App Engine
This is Rietveld 408576698