Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: chrome/browser/ui/webui/plugins_ui.cc

Issue 1255943002: One-time migration of NPAPI Flash to PPAPI Flash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use correct plugin name on OS X Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_prefs_factory.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/plugins_ui.h" 5 #include "chrome/browser/ui/webui/plugins_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 base::DictionaryValue* plugin_file = new base::DictionaryValue(); 369 base::DictionaryValue* plugin_file = new base::DictionaryValue();
370 plugin_file->SetString("name", group_plugin.name); 370 plugin_file->SetString("name", group_plugin.name);
371 371
372 // If this plugin is Pepper Flash, and the plugin path is the same as the 372 // If this plugin is Pepper Flash, and the plugin path is the same as the
373 // path for the Pepper Flash System plugin, then mark this plugin 373 // path for the Pepper Flash System plugin, then mark this plugin
374 // description as the system plugin to help the user disambiguate the 374 // description as the system plugin to help the user disambiguate the
375 // two plugins. 375 // two plugins.
376 base::string16 desc = group_plugin.desc; 376 base::string16 desc = group_plugin.desc;
377 if (group_plugin.is_pepper_plugin() && 377 if (group_plugin.is_pepper_plugin() &&
378 group_plugin.name == base::ASCIIToUTF16(content::kFlashPluginName)) { 378 group_plugin.name == base::ASCIIToUTF16(content::kFlashPluginName)) {
379 base::FilePath system_path; 379 base::FilePath system_flash_path;
380 PathService::Get(chrome::DIR_PEPPER_FLASH_SYSTEM_PLUGIN, &system_path); 380 PathService::Get(chrome::FILE_PEPPER_FLASH_SYSTEM_PLUGIN,
381 if (group_plugin.path.DirName() == system_path) { 381 &system_flash_path);
382 if (base::FilePath::CompareEqualIgnoreCase(group_plugin.path.value(),
383 system_flash_path.value())) {
382 #if defined(GOOGLE_CHROME_BUILD) 384 #if defined(GOOGLE_CHROME_BUILD)
383 // Existing documentation for debugging Flash describe this plugin as 385 // Existing documentation for debugging Flash describe this plugin as
384 // "Debug" so preserve this nomenclature here. 386 // "Debug" so preserve this nomenclature here.
385 desc += base::ASCIIToUTF16(" Debug"); 387 desc += base::ASCIIToUTF16(" Debug");
386 #else 388 #else
387 // On Chromium, we can name it what it really is; the system plugin. 389 // On Chromium, we can name it what it really is; the system plugin.
388 desc += base::ASCIIToUTF16(" System"); 390 desc += base::ASCIIToUTF16(" System");
389 #endif 391 #endif
390 } 392 }
391 } 393 }
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 } 521 }
520 522
521 // static 523 // static
522 void PluginsUI::RegisterProfilePrefs( 524 void PluginsUI::RegisterProfilePrefs(
523 user_prefs::PrefRegistrySyncable* registry) { 525 user_prefs::PrefRegistrySyncable* registry) {
524 registry->RegisterBooleanPref(prefs::kPluginsShowDetails, false); 526 registry->RegisterBooleanPref(prefs::kPluginsShowDetails, false);
525 registry->RegisterDictionaryPref( 527 registry->RegisterDictionaryPref(
526 prefs::kContentSettingsPluginWhitelist, 528 prefs::kContentSettingsPluginWhitelist,
527 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 529 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
528 } 530 }
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_prefs_factory.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698