Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename IDL argument and method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html ('K') | « Source/modules/serviceworkers/RespondWithObserver.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/Source/modules/serviceworkers/RespondWithObserver.cpp b/Source/modules/serviceworkers/RespondWithObserver.cpp

index 98b792df6a7c071dd698d8aa11de744a5e32bcbf..b63f7e1cdf35d5cc3a76825b77ae0a9511e06431 100644

--- a/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -132,7 +132,7 @@ void RespondWithObserver::didDispatchEvent(bool defaultPrevented)

m_state = Done;

}

-void RespondWithObserver::respondWith(ScriptState* scriptState, const ScriptValue& value, ExceptionState& exceptionState)

+void RespondWithObserver::respondWith(ScriptState* scriptState, ScriptPromise& scriptPromise, ExceptionState& exceptionState)

{

if (m_state != Initial) {

exceptionState.throwDOMException(InvalidStateError, "The fetch event has already been responded to.");

@@ -140,7 +140,7 @@ void RespondWithObserver::respondWith(ScriptState* scriptState, const ScriptValu

}

m_state = Pending;

- ScriptPromise::cast(scriptState, value).then(

+ scriptPromise.then(

ThenFunction::createFunction(scriptState, this, ThenFunction::Fulfilled),

ThenFunction::createFunction(scriptState, this, ThenFunction::Rejected));

}