Source/modules/serviceworkers/RespondWithObserver.h - Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename IDL argument and method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html ('K') | « Source/modules/serviceworkers/FetchEvent.idl ('k') | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h

index 74c0766ec91dbcb528ccb78f4ea1e90f8ce0241e..0e12cd3a65292f4c1696daaab6fe3309604b225b 100644

--- a/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/Source/modules/serviceworkers/RespondWithObserver.h

@@ -15,6 +15,7 @@ namespace blink {

class ExceptionState;

class ExecutionContext;

+class ScriptPromise;

class ScriptState;

class ScriptValue;

@@ -31,7 +32,7 @@ public:

// Observes the promise and delays calling didHandleFetchEvent() until the

// given promise is resolved or rejected.

- void respondWith(ScriptState*, const ScriptValue&, ExceptionState&);

+ void respondWith(ScriptState*, ScriptPromise&, ExceptionState&);

void responseWasRejected(WebServiceWorkerResponseError);

void responseWasFulfilled(const ScriptValue&);