Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 125533003: Support multiple flags in RuntimeEnabled (Closed)

Created:
6 years, 11 months ago by gyuyoung-inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support multiple flags in RuntimeEnabled Some runtime features use multiple flags. This cl start to support the multiple features in RuntimeEnabled. '&' is used for separating features. BUG=N/A

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +11 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
6 years, 11 months ago (2014-01-07 04:20:42 UTC) #1
haraken
Please add one test case to run-bindings-tests. https://codereview.chromium.org/125533003/diff/1/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/125533003/diff/1/Source/bindings/scripts/code_generator_v8.pm#newcode5837 Source/bindings/scripts/code_generator_v8.pm:5837: # Given ...
6 years, 11 months ago (2014-01-07 04:56:19 UTC) #2
eseidel
Most flags have instead used the depends_on= attribute in the flags themselves. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in&q=RuntimeEnabledFeatures.in&sq=package:chromium&type=cs&l=128
6 years, 11 months ago (2014-01-07 05:58:35 UTC) #3
gyuyoung-inactive
6 years, 11 months ago (2014-01-07 08:33:45 UTC) #4
On 2014/01/07 05:58:35, eseidel wrote:
> Most flags have instead used the depends_on= attribute in the flags
themselves.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

It looks this is one I want to use. If there will be any situation that we need
to use this patch, I will raise this again. Thanks, haraken and eseidel.

Powered by Google App Engine
This is Rietveld 408576698