Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 125533003: Support multiple flags in RuntimeEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 671aae9aac94b806cbf22f93d6253c6a150f9abd..9045d7581395bb42732401ef975b68b72411475e 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -5834,9 +5834,19 @@ sub GetRuntimeEnabledFunctionName
{
my $signature = shift;
- # Given [RuntimeEnabled=FeatureName],
+ # Given [RuntimeEnabled=FeatureName,
haraken 2014/01/07 04:56:19 Add ']' back.
# return RuntimeEnabledFeatures::{featureName}Enabled;
+ # If [RuntimeEnabled=FeatureName1&FeatureName2] is given,
+ # return RuntimeEnabledFeatures::{featureName1}Enabled && RuntimeEnabledFeatures::{featureName2}Enabled;
my $featureName = ToMethodName($signature->extendedAttributes->{"RuntimeEnabled"});
+
+ my $operator = ($featureName =~ /&/ ? '&' : '');
+ if ($operator) {
+ my %featureNames;
+ map { $featureNames{lcfirst($_)} = 1 } split('\\' . $operator, $featureName);
+ return "RuntimeEnabledFeatures::" . join("Enabled() $operator$operator RuntimeEnabledFeatures::", sort keys %featureNames) . "Enabled";
+ }
haraken 2014/01/07 04:56:19 A bit more readable way to do this would be: my $
+
return "RuntimeEnabledFeatures::${featureName}Enabled";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698