Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1255133004:
Add SkLights class (Closed)
|
Created:
5 years, 4 months ago by robertphillips Modified:
4 years, 6 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd SkLights class
The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader).
This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1255133004
Committed: https://skia.googlesource.com/skia/+/93966d88efb090f77f6109f0e19cc982b83d5da9
Patch Set 1 #Patch Set 2 : Actually add SkLights.h #
Total comments: 4
Patch Set 3 : Switch editor to builder #Patch Set 4 : Increase constiness #Patch Set 5 : update to ToT #Patch Set 6 : update to ToT #Patch Set 7 : Fix include path #Patch Set 8 : Rm lingering SkNEW #Patch Set 9 : Rm Lingering SkNEW #Messages
Total messages: 25 (12 generated)
robertphillips@google.com changed reviewers: + bsalomon@google.com, jvanverth@google.com, reed@google.com
ping
https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h File include/core/SkLights.h (right): https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h... include/core/SkLights.h:22: kInfinite_LightType directional? https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h... include/core/SkLights.h:54: class Editor { Maybe just have a builder and immutable light set? I wish we had that pattern for path rather than path/pathref/editor.
https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h File include/core/SkLights.h (right): https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h... include/core/SkLights.h:22: kInfinite_LightType On 2015/08/05 14:58:38, bsalomon wrote: > directional? Done. https://codereview.chromium.org/1255133004/diff/20001/include/core/SkLights.h... include/core/SkLights.h:54: class Editor { On 2015/08/05 14:58:38, bsalomon wrote: > Maybe just have a builder and immutable light set? I wish we had that pattern > for path rather than path/pathref/editor. Done.
lgtm
Description was changed from ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). ========== to ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133004/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133004/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133004/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1255133004/#ps160001 (title: "Rm Lingering SkNEW")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133004/160001
Message was sent while issue was closed.
Description was changed from ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add SkLights class The SkLights class is intended to be passed to the drawLitAtlas call (and then on to SkLightingShader). This CL is calved off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93966d88efb090f77f6109f0e19cc982b83d5da9 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as https://skia.googlesource.com/skia/+/93966d88efb090f77f6109f0e19cc982b83d5da9 |
