Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: components/browser_watcher/watcher_metrics_provider_win.cc

Issue 1255073002: clang/win: Fix most -Wunused-function warnings in Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/watcher_metrics_provider_win.cc
diff --git a/components/browser_watcher/watcher_metrics_provider_win.cc b/components/browser_watcher/watcher_metrics_provider_win.cc
index 2798ae56c42d0fce3d9a17387b60cd78df1b33bc..76352b8b36a4e7731509c27d5c1ea21646dfb25f 100644
--- a/components/browser_watcher/watcher_metrics_provider_win.cc
+++ b/components/browser_watcher/watcher_metrics_provider_win.cc
@@ -18,14 +18,12 @@ namespace browser_watcher {
namespace {
-void CompileAsserts() {
- // Process ID APIs on Windows talk in DWORDs, whereas for string formatting
- // and parsing, this code uses int. In practice there are no process IDs with
- // the high bit set on Windows, so there's no danger of overflow if this is
- // done consistently.
- static_assert(sizeof(DWORD) == sizeof(int),
- "process ids are expected to be no larger than int");
-}
+// Process ID APIs on Windows talk in DWORDs, whereas for string formatting
+// and parsing, this code uses int. In practice there are no process IDs with
+// the high bit set on Windows, so there's no danger of overflow if this is
+// done consistently.
+static_assert(sizeof(DWORD) == sizeof(int),
+ "process ids are expected to be no larger than int");
// This function does soft matching on the PID recorded in the key only.
// Due to PID reuse, the possibility exists that the process that's now live

Powered by Google App Engine
This is Rietveld 408576698