Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: content/common/sandbox_win.cc

Issue 1255073002: clang/win: Fix most -Wunused-function warnings in Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_service_impl.cc ('k') | content/renderer/npapi/webplugin_delegate_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index f6d9cf258729da3ece34b36fbde8386427e94da7..64f229c7c129533939827b11b8e0a5603b3aec4f 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -121,6 +121,7 @@ const wchar_t* const kTroublesomeDlls[] = {
L"winstylerthemehelper.dll" // Tuneup utilities 2006.
};
+#if !defined(NACL_WIN64)
// Adds the policy rules for the path and path\ with the semantic |access|.
// If |children| is set to true, we need to add the wildcard rules to also
// apply the rule to the subfiles and subfolders.
@@ -152,26 +153,7 @@ bool AddDirectory(int path, const wchar_t* sub_dir, bool children,
return true;
}
-
-// Adds the policy rules for the path and path\* with the semantic |access|.
-// We need to add the wildcard rules to also apply the rule to the subkeys.
-bool AddKeyAndSubkeys(std::wstring key,
- sandbox::TargetPolicy::Semantics access,
- sandbox::TargetPolicy* policy) {
- sandbox::ResultCode result;
- result = policy->AddRule(sandbox::TargetPolicy::SUBSYS_REGISTRY, access,
- key.c_str());
- if (result != sandbox::SBOX_ALL_OK)
- return false;
-
- key += L"\\*";
- result = policy->AddRule(sandbox::TargetPolicy::SUBSYS_REGISTRY, access,
- key.c_str());
- if (result != sandbox::SBOX_ALL_OK)
- return false;
-
- return true;
cpu_(ooo_6.6-7.5) 2015/07/28 19:37:21 this is the only one I am sad to see go, because i
Nico 2015/07/28 19:38:58 It's not gone, it's just out of sight.
-}
+#endif // !defined(NACL_WIN64)
// Compares the loaded |module| file name matches |module_name|.
bool IsExpandedModuleName(HMODULE module, const wchar_t* module_name) {
« no previous file with comments | « content/browser/plugin_service_impl.cc ('k') | content/renderer/npapi/webplugin_delegate_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698