Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1255073002: clang/win: Fix most -Wunused-function warnings in Chromium code. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, sadrul, gavinp+disk_chromium.org, chromoting-reviews_chromium.org, grt+watch_chromium.org, jam, rickyz+watch_chromium.org, piman+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, wfh+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, erikwright+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix most -Wunused-function warnings in Chromium code. No intended behavior change. BUG=505316 TBR=armansito Committed: https://crrev.com/84dff94bdb4c72490263b1dcba295dd2ff6dbc9f Cr-Commit-Position: refs/heads/master@{#340761}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : mac #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -299 lines) Patch
M base/files/file_util_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/app/image_pre_reader_win.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 2 3 2 chunks +0 lines, -66 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/installer/util/language_selector.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/base/chrome_process_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M components/crash/app/breakpad_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/sandbox_win.cc View 2 chunks +2 lines, -20 lines 2 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/disk_cache/simple/simple_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M ppapi/tests/test_file_io.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M printing/printed_document_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M sandbox/win/src/crosscall_params.h View 1 chunk +1 line, -4 lines 0 comments Download
M sandbox/win/src/process_mitigations_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 2 3 4 4 chunks +3 lines, -3 lines 0 comments Download
M ui/base/test/ui_controls_internal_win.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M win8/metro_driver/direct3d_helper.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Nico
cpu: everything
5 years, 4 months ago (2015-07-26 03:19:49 UTC) #2
Nico
cpu: ping
5 years, 4 months ago (2015-07-28 04:05:31 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1255073002/diff/80001/content/common/sandbox_win.cc File content/common/sandbox_win.cc (left): https://codereview.chromium.org/1255073002/diff/80001/content/common/sandbox_win.cc#oldcode173 content/common/sandbox_win.cc:173: return true; this is the only one I ...
5 years, 4 months ago (2015-07-28 19:37:22 UTC) #4
Nico
Thanks! https://codereview.chromium.org/1255073002/diff/80001/content/common/sandbox_win.cc File content/common/sandbox_win.cc (left): https://codereview.chromium.org/1255073002/diff/80001/content/common/sandbox_win.cc#oldcode173 content/common/sandbox_win.cc:173: return true; On 2015/07/28 19:37:21, cpu wrote: > ...
5 years, 4 months ago (2015-07-28 19:38:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255073002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255073002/80001
5 years, 4 months ago (2015-07-28 19:39:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/82745)
5 years, 4 months ago (2015-07-28 19:50:40 UTC) #9
Nico
tbr armansito for device/bluetooth, but I think https://codereview.chromium.org/255473002/ should be reverted (which made that owners ...
5 years, 4 months ago (2015-07-28 20:00:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255073002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255073002/80001
5 years, 4 months ago (2015-07-28 20:07:47 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-07-28 20:47:51 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 20:48:33 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/84dff94bdb4c72490263b1dcba295dd2ff6dbc9f
Cr-Commit-Position: refs/heads/master@{#340761}

Powered by Google App Engine
This is Rietveld 408576698