Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254983003: Componentize DriveMetricsProvider* (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize DriveMetricsProvider* This metrics provider is used on iOS, so to enable clean integration on iOS this CL componentizes it and injects its //chrome-level dependencies from the embedder. BUG=512426 Committed: https://crrev.com/b5c6b5a18863e2e9094b5bb3328edab690fa7111 Cr-Commit-Position: refs/heads/master@{#341183}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -495 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +6 lines, -2 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_android.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_ios.mm View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_linux.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_mac.mm View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/metrics/drive_metrics_provider_win.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A + components/metrics/drive_metrics_provider.h View 1 5 chunks +25 lines, -11 lines 0 comments Download
A + components/metrics/drive_metrics_provider.cc View 5 chunks +18 lines, -11 lines 0 comments Download
A + components/metrics/drive_metrics_provider_android.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + components/metrics/drive_metrics_provider_ios.mm View 2 chunks +5 lines, -1 line 0 comments Download
A + components/metrics/drive_metrics_provider_linux.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + components/metrics/drive_metrics_provider_mac.mm View 4 chunks +8 lines, -6 lines 0 comments Download
A + components/metrics/drive_metrics_provider_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
A + components/metrics/drive_metrics_provider_win.cc View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
blundell
5 years, 4 months ago (2015-07-30 16:49:05 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1254983003/diff/1/components/metrics/drive_metrics_provider.h File components/metrics/drive_metrics_provider.h (right): https://codereview.chromium.org/1254983003/diff/1/components/metrics/drive_metrics_provider.h#newcode11 components/metrics/drive_metrics_provider.h:11: #include "base/memory/scoped_ptr.h" If this is for the scoped_refptr, ...
5 years, 4 months ago (2015-07-30 16:59:52 UTC) #3
blundell
https://codereview.chromium.org/1254983003/diff/1/components/metrics/drive_metrics_provider.h File components/metrics/drive_metrics_provider.h (right): https://codereview.chromium.org/1254983003/diff/1/components/metrics/drive_metrics_provider.h#newcode11 components/metrics/drive_metrics_provider.h:11: #include "base/memory/scoped_ptr.h" On 2015/07/30 16:59:52, Alexei Svitkine wrote: > ...
5 years, 4 months ago (2015-07-30 19:17:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254983003/20001
5 years, 4 months ago (2015-07-30 19:18:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 20:18:46 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 20:19:57 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b5c6b5a18863e2e9094b5bb3328edab690fa7111
Cr-Commit-Position: refs/heads/master@{#341183}

Powered by Google App Engine
This is Rietveld 408576698