Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: components/metrics/drive_metrics_provider.cc

Issue 1254983003: Componentize DriveMetricsProvider* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/drive_metrics_provider.h" 5 #include "components/metrics/drive_metrics_provider.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/metrics/histogram_macros.h" 12 #include "base/metrics/histogram_macros.h"
13 #include "base/path_service.h" 13 #include "base/path_service.h"
14 #include "base/task_runner_util.h"
14 #include "base/time/time.h" 15 #include "base/time/time.h"
15 #include "chrome/common/chrome_paths.h"
16 #include "content/public/browser/browser_thread.h"
17 16
18 DriveMetricsProvider::DriveMetricsProvider() : weak_ptr_factory_(this) {} 17 namespace metrics {
18
19 DriveMetricsProvider::DriveMetricsProvider(
20 scoped_refptr<base::SequencedTaskRunner> file_thread,
21 int local_state_path_key)
22 : file_thread_(file_thread),
23 local_state_path_key_(local_state_path_key),
24 weak_ptr_factory_(this) {}
19 25
20 DriveMetricsProvider::~DriveMetricsProvider() {} 26 DriveMetricsProvider::~DriveMetricsProvider() {}
21 27
22 void DriveMetricsProvider::ProvideSystemProfileMetrics( 28 void DriveMetricsProvider::ProvideSystemProfileMetrics(
23 metrics::SystemProfileProto* system_profile_proto) { 29 metrics::SystemProfileProto* system_profile_proto) {
24 auto* hardware = system_profile_proto->mutable_hardware(); 30 auto* hardware = system_profile_proto->mutable_hardware();
25 FillDriveMetrics(metrics_.app_drive, hardware->mutable_app_drive()); 31 FillDriveMetrics(metrics_.app_drive, hardware->mutable_app_drive());
26 FillDriveMetrics(metrics_.user_data_drive, 32 FillDriveMetrics(metrics_.user_data_drive,
27 hardware->mutable_user_data_drive()); 33 hardware->mutable_user_data_drive());
28 } 34 }
29 35
30 void DriveMetricsProvider::GetDriveMetrics(const base::Closure& done) { 36 void DriveMetricsProvider::GetDriveMetrics(const base::Closure& done) {
31 got_metrics_callback_ = done; 37 got_metrics_callback_ = done;
32 38
33 content::BrowserThread::PostTaskAndReplyWithResult( 39 base::PostTaskAndReplyWithResult(
34 content::BrowserThread::FILE, FROM_HERE, 40 file_thread_.get(), FROM_HERE,
35 base::Bind(&DriveMetricsProvider::GetDriveMetricsOnFileThread), 41 base::Bind(&DriveMetricsProvider::GetDriveMetricsOnFileThread,
42 local_state_path_key_),
36 base::Bind(&DriveMetricsProvider::GotDriveMetrics, 43 base::Bind(&DriveMetricsProvider::GotDriveMetrics,
37 weak_ptr_factory_.GetWeakPtr())); 44 weak_ptr_factory_.GetWeakPtr()));
38 } 45 }
39 46
40 DriveMetricsProvider::SeekPenaltyResponse::SeekPenaltyResponse() 47 DriveMetricsProvider::SeekPenaltyResponse::SeekPenaltyResponse()
41 : success(false) {} 48 : success(false) {}
42 49
43 // static 50 // static
44 DriveMetricsProvider::DriveMetrics 51 DriveMetricsProvider::DriveMetrics
45 DriveMetricsProvider::GetDriveMetricsOnFileThread() { 52 DriveMetricsProvider::GetDriveMetricsOnFileThread(int local_state_path_key) {
46 DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
47
48 DriveMetricsProvider::DriveMetrics metrics; 53 DriveMetricsProvider::DriveMetrics metrics;
49 QuerySeekPenalty(base::FILE_EXE, &metrics.app_drive); 54 QuerySeekPenalty(base::FILE_EXE, &metrics.app_drive);
50 QuerySeekPenalty(chrome::FILE_LOCAL_STATE, &metrics.user_data_drive); 55 QuerySeekPenalty(local_state_path_key, &metrics.user_data_drive);
51 return metrics; 56 return metrics;
52 } 57 }
53 58
54 // static 59 // static
55 void DriveMetricsProvider::QuerySeekPenalty( 60 void DriveMetricsProvider::QuerySeekPenalty(
56 int path_service_key, 61 int path_service_key,
57 DriveMetricsProvider::SeekPenaltyResponse* response) { 62 DriveMetricsProvider::SeekPenaltyResponse* response) {
58 DCHECK(response); 63 DCHECK(response);
59 64
60 base::FilePath path; 65 base::FilePath path;
(...skipping 20 matching lines...) Expand all
81 metrics_ = metrics; 86 metrics_ = metrics;
82 got_metrics_callback_.Run(); 87 got_metrics_callback_.Run();
83 } 88 }
84 89
85 void DriveMetricsProvider::FillDriveMetrics( 90 void DriveMetricsProvider::FillDriveMetrics(
86 const DriveMetricsProvider::SeekPenaltyResponse& response, 91 const DriveMetricsProvider::SeekPenaltyResponse& response,
87 metrics::SystemProfileProto::Hardware::Drive* drive) { 92 metrics::SystemProfileProto::Hardware::Drive* drive) {
88 if (response.success) 93 if (response.success)
89 drive->set_has_seek_penalty(response.has_seek_penalty); 94 drive->set_has_seek_penalty(response.has_seek_penalty);
90 } 95 }
96
97 } // namespace metrics
OLDNEW
« no previous file with comments | « components/metrics/drive_metrics_provider.h ('k') | components/metrics/drive_metrics_provider_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698