Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1254963011: Revert of Animations: Port ProgrammaticScrollAnimator to use compositor timelines (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@linkhigh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Animations: Port ProgrammaticScrollAnimator to use compositor timelines (patchset #7 id:120001 of https://codereview.chromium.org/1133513002/) Reason for revert: Since this landed, 8 out of 9 runs of virtual/threaded_animation_timelines/fast/scroll-behavior/overflow-scroll-root-frame-animates.html have timed out on WebKit Linux MSAN: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded_animation_timelines%2Ffast%2Fscroll-behavior%2Foverflow-scroll-root-frame-animates.html There has also been a timeout on WebKit Win Oilpan (dbg): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20(dbg)/builds/1889 Original issue's description: > Animations: Port ProgrammaticScrollAnimator to use compositor timelines > > Use AnimationPlayer to add animations if new system enabled. > > Previous episode: https://codereview.chromium.org/1119763003/ > What we want to achieve: https://codereview.chromium.org/1131833002 > > BUG=394777 > R=ajuma@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199766 TBR=ajuma@chromium.org,vollick@chromium.org,loyso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=394777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -132 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/threaded_animation_timelines/fast/scroll-behavior/README.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 4 chunks +1 line, -16 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.h View 4 chunks +2 lines, -16 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 6 chunks +6 lines, -79 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
Created Revert of Animations: Port ProgrammaticScrollAnimator to use compositor timelines
5 years, 4 months ago (2015-07-31 10:15:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254963011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254963011/1
5 years, 4 months ago (2015-07-31 10:16:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199815
5 years, 4 months ago (2015-07-31 10:17:00 UTC) #3
johnme
5 years, 4 months ago (2015-07-31 10:48:33 UTC) #4
Message was sent while issue was closed.
It also caused
virtual/threaded_animation_timelines/fast/scroll-behavior/main-frame-scrollBy.html
to timeout on Win (dbg):
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vir...

Powered by Google App Engine
This is Rietveld 408576698