Source/core/page/scrolling/ScrollingCoordinator.h - Issue 1254963011: Revert of Animations: Port ProgrammaticScrollAnimator to use compositor timelines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.h

Issue 1254963011: Revert of Animations: Port ProgrammaticScrollAnimator to use compositor timelines (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@linkhigh

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/threaded_animation_timelines/fast/scroll-behavior/README.txt ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.h b/Source/core/page/scrolling/ScrollingCoordinator.h

index 7838814eec051f094069e535a993cba793442d9b..8631c2db88628453ba32a46f53e090c41b9d84c5 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -48,7 +48,6 @@

class Page;

class Region;

class ScrollableArea;

-class WebCompositorAnimationTimeline;

class CORE_EXPORT ScrollingCoordinator final : public NoBaseWillBeGarbageCollectedFinalized<ScrollingCoordinator> {

WTF_MAKE_NONCOPYABLE(ScrollingCoordinator);

@@ -152,8 +151,6 @@

bool frameViewIsDirty() const;

- OwnPtr<WebCompositorAnimationTimeline> m_programmaticScrollAnimatorTimeline;

using ScrollbarMap = WillBeHeapHashMap<RawPtrWillBeMember<ScrollableArea>, OwnPtr<WebScrollbarLayer>>;

ScrollbarMap m_horizontalScrollbars;

ScrollbarMap m_verticalScrollbars;