Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254943002: Fix Ganesh drawAtlas bug with quad colors (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
bsalomon, caryclark, eseidel
CC:
eseidel, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Ganesh drawAtlas bug with quad colors Ganesh was not expanding the quad colors to vertex colors before calling drawVertices. The new GM would've caught this bug and reveals Ganesh's limitations re the various xfer modes used with drawAtlas (i.e., w/o AA Ganesh only supports kModulate, w/ AA Ganesh only supports the coefficient-based xfer modes). Committed: https://skia.googlesource.com/skia/+/29ccdf86ab0a1649fd775c9431891bacb1391e99

Patch Set 1 #

Patch Set 2 : revert changes to arcofzorro GM #

Patch Set 3 : clean up #

Patch Set 4 : expand GM to cover AA vs. non-AA #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -1 line) Patch
A gm/drawatlascolor.cpp View 1 2 3 1 chunk +177 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +14 lines, -1 line 2 comments Download

Messages

Total messages: 14 (5 generated)
robertphillips
5 years, 5 months ago (2015-07-24 16:26:32 UTC) #2
caryclark
lgtm (the gm part)
5 years, 5 months ago (2015-07-24 16:35:09 UTC) #3
bsalomon
On 2015/07/24 16:35:09, caryclark wrote: > lgtm (the gm part) lgtm (the other part)
5 years, 5 months ago (2015-07-24 16:59:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254943002/60001
5 years, 5 months ago (2015-07-24 17:09:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 17:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254943002/60001
5 years, 5 months ago (2015-07-24 17:20:11 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/29ccdf86ab0a1649fd775c9431891bacb1391e99
5 years, 5 months ago (2015-07-24 17:20:49 UTC) #11
eseidel
https://codereview.chromium.org/1254943002/diff/60001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1254943002/diff/60001/src/gpu/SkGpuDevice.cpp#newcode1733 src/gpu/SkGpuDevice.cpp:1733: this->drawVertices(d, SkCanvas::kTriangles_VertexMode, vertCount, verts, texs, vertCols, xfer, so vertCols ...
5 years, 5 months ago (2015-07-24 17:22:45 UTC) #13
robertphillips
5 years, 5 months ago (2015-07-24 17:55:50 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/1254943002/diff/60001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1254943002/diff/60001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1733: this->drawVertices(d,
SkCanvas::kTriangles_VertexMode, vertCount, verts, texs, vertCols, xfer,
On 2015/07/24 17:22:44, eseidel wrote:
> so vertCols is 4x the size of colors, right?  Was the previous code reading
> random values off the end of colors?

Yep - that resulted in the flickering.

Powered by Google App Engine
This is Rietveld 408576698