Fix Ganesh drawAtlas bug with quad colors

src/gpu/SkGpuDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkGpuDevice.h"
 
 #include "GrBlurUtils.h"
@@ skipping 1696 matching lines @@
 
     for (int i = 0; i < count; ++i) {
         xform[i].toQuad(texRect[i].width(), texRect[i].height(), verts);
         texRect[i].toQuad(texs);
         append_quad_indices(indices, i);
         verts += 4;
         texs += 4;
         indices += 6;
     }
 
+    SkAutoTMalloc<SkColor> colorStorage;
+    SkColor* vertCols = NULL;
+    if (colors) {
+        colorStorage.reset(vertCount);
+        vertCols = colorStorage.get();
+
+        for (int i = 0; i < count; ++i) {
+             vertCols[0] = vertCols[1] = vertCols[2] = vertCols[3] = colors[i];
+             vertCols += 4;
+        }
+    }
+
     verts = vertStorage.get();
     texs = verts + vertCount;
+    vertCols = colorStorage.get();
     indices = indexStorage.get();
-    this->drawVertices(d, SkCanvas::kTriangles_VertexMode, vertCount, verts, texs, colors, xfer,
+    this->drawVertices(d, SkCanvas::kTriangles_VertexMode, vertCount, verts, texs, vertCols, xfer,

[eseidel, 2015/07/24 17:22:44]

so vertCols is 4x the size of colors, right?  Was the previous code reading
random values off the end of colors?

[robertphillips, 2015/07/24 17:55:50]

Yep - that resulted in the flickering.

                        indices, indexCount, p);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 void SkGpuDevice::drawText(const SkDraw& draw, const void* text,
                            size_t byteLength, SkScalar x, SkScalar y,
                            const SkPaint& paint) {
     CHECK_SHOULD_DRAW(draw);
     GR_CREATE_TRACE_MARKER_CONTEXT("SkGpuDevice::drawText", fContext);
@@ skipping 156 matching lines @@
 #endif
 }
 
 SkImageFilter::Cache* SkGpuDevice::getImageFilterCache() {
     // We always return a transient cache, so it is freed after each
     // filter traversal.
     return SkImageFilter::Cache::Create(kDefaultImageFilterCacheSize);
 }
 
 #endif