Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1254833006: Fix Python pylint warnings (Closed)

Created:
5 years, 4 months ago by mkollaro
Modified:
5 years, 4 months ago
Reviewers:
bajones, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Python pylint warnings Fix warnings about "redefining build-in 'file'". Also rename 'Write' into 'write' and 'Close' into 'close' to make future replacement of CWriter with something more pythonic easier. BUG=498797 Committed: https://crrev.com/cf4613a24a12cdf5cd6c457ed07fddbae1d23795 Cr-Commit-Position: refs/heads/master@{#341497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1437 lines, -1437 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 177 chunks +1437 lines, -1437 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
mkollaro
Sorry for the long diff, but it's pretty much just s/file.Write/f.write/.
5 years, 4 months ago (2015-07-31 18:17:30 UTC) #2
bajones
LGTM
5 years, 4 months ago (2015-07-31 18:25:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254833006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254833006/1
5 years, 4 months ago (2015-08-03 07:46:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 07:53:30 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 07:54:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf4613a24a12cdf5cd6c457ed07fddbae1d23795
Cr-Commit-Position: refs/heads/master@{#341497}

Powered by Google App Engine
This is Rietveld 408576698