Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1265023002: Refactor gpu code generation (Closed)

Created:
5 years, 4 months ago by mkollaro
Modified:
5 years, 4 months ago
Reviewers:
Zhenyao Mo, bajones, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@python-pep8-file
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor gpu code generation Make CWriter and CHeaderWriter more pythonic - use the 'with' statement to automatically close the file. The 'write' function now writes directly into the file and not into a string. Bug=None Committed: https://crrev.com/a5535301ce813d9f709c4f7cee1f5d1bc975cb3f Cr-Commit-Position: refs/heads/master@{#342077}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+811 lines, -905 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 9 chunks +811 lines, -905 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mkollaro
Most of the changes are just the extra indent caused by the 'with' statement, I ...
5 years, 4 months ago (2015-07-31 18:21:23 UTC) #2
piman
piman->zmo
5 years, 4 months ago (2015-08-03 21:25:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265023002/20001
5 years, 4 months ago (2015-08-05 11:56:48 UTC) #6
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 4 months ago (2015-08-05 11:56:50 UTC) #8
Zhenyao Mo
LGTM
5 years, 4 months ago (2015-08-06 03:38:32 UTC) #9
Zhenyao Mo
On 2015/08/06 03:38:32, Zhenyao Mo wrote: > LGTM Sorry about the delay, but the shifting ...
5 years, 4 months ago (2015-08-06 03:39:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265023002/20001
5 years, 4 months ago (2015-08-06 08:11:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-06 08:19:53 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 08:20:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5535301ce813d9f709c4f7cee1f5d1bc975cb3f
Cr-Commit-Position: refs/heads/master@{#342077}

Powered by Google App Engine
This is Rietveld 408576698