Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1254793002: Modifies size of ring buffer in shared memory on the audio capture side (Closed)

Created:
5 years, 5 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modifies size of ring buffer in shared memory on the audio capture side. We have seen reports in Chrome where segments of repeated input audio has damaged AEC performance in WebRTC clients. This patch is an attempt to limit the number of possible places in Chrome where such a patter could be created. It is a speculative patch and the idea is that it should live in Canary for a while so we can see if there are any positive effects. TBR=tommi BUG=b/13976602 TEST=manual tests of different WebRTC clients running in loopback to ensure that no audio artifacts can be detected Committed: https://crrev.com/bda4fc7018c3ce93d88b74461a065f9eaf0b8b5f Cr-Commit-Position: refs/heads/master@{#340261}

Patch Set 1 #

Patch Set 2 : Added comments #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M media/audio/audio_input_device.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
henrika (OOO until Aug 14)
TBR tommi since we would like to start monitoring any effects of this change and ...
5 years, 5 months ago (2015-07-24 09:25:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254793002/40001
5 years, 5 months ago (2015-07-24 09:26:32 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-24 12:09:42 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bda4fc7018c3ce93d88b74461a065f9eaf0b8b5f Cr-Commit-Position: refs/heads/master@{#340261}
5 years, 5 months ago (2015-07-24 12:10:25 UTC) #6
DaleCurtis
Hmm, this is a dangerous patch -- I suspect you're going to break a lot ...
5 years, 5 months ago (2015-07-24 16:16:56 UTC) #8
henrika (OOO until Aug 14)
I did this as an experiment on Canary to see if we can see any ...
5 years, 5 months ago (2015-07-24 19:39:08 UTC) #9
DaleCurtis
CrOS had a recent bug which was causing problems like you describe, https://code.google.com/p/chrome-os-partner/issues/detail?id=41120 No idea ...
5 years, 5 months ago (2015-07-24 19:41:21 UTC) #10
henrika (OOO until Aug 14)
We have mainly seen it on Windows and Mac. On Fri, Jul 24, 2015 at ...
5 years, 5 months ago (2015-07-24 19:43:35 UTC) #11
Henrik Grunell
5 years, 4 months ago (2015-08-07 11:41:36 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1277173002/ by grunell@chromium.org.

The reason for reverting is: This was an speculative change and should now be
reverted. There is no sign that this change would fix or improve the issue..

Powered by Google App Engine
This is Rietveld 408576698