Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: media/audio/audio_input_device.cc

Issue 1254793002: Modifies size of ring buffer in shared memory on the audio capture side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_device.cc
diff --git a/media/audio/audio_input_device.cc b/media/audio/audio_input_device.cc
index 9f46b55a1b9f365facd573b5f0783cd15f9923af..07eb11c2b77b16c2ba02efda82c5c7491b87693c 100644
--- a/media/audio/audio_input_device.cc
+++ b/media/audio/audio_input_device.cc
@@ -17,7 +17,13 @@ namespace media {
// in order to avoid data overwriting. This number can be any positive number,
// dependent how fast the renderer process can pick up captured data from
// shared memory.
-static const int kRequestedSharedMemoryCount = 10;
+// TODO(henrika): figure out a suitable size of this ring buffer.
+// We have seen reports in Chrome where segments of repeated input audio has
+// damaged AEC performance in WebRTC clients. By setting its value to 1, we
+// reduce the number of places in Chrome where such a patteren could possibly
+// be created. The original value of kRequestedSharedMemoryCount was 10.
+// See b/13976602 for details.
+static const int kRequestedSharedMemoryCount = 1;
// Takes care of invoking the capture callback on the audio thread.
// An instance of this class is created for each capture stream in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698