Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1254723012: Add support for /DEBUG:FASTLINK to gyp and gn files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by brucedawson
Modified:
2 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for /DEBUG:FASTLINK to gyp and gn files. VC++ 2015 has a /DEBUG:FASTLINK option that can significantly improve link performance on developer machines. Compared to normal VS 2015 links it reduces elapsed time by 33-55% and reduces peak working set by 65-90%. PDB sizes are reduced by 65-72%. /DEBUG:FASTLINK works by having PDB files reference symbols in .obj and .lib files instead of copying the debug information. This means that PDBs only work on the machine they were created on, and only as long as the .obj and .lib files exist, but this constraint matches local-developer-builds very nicely. /DEBUG:FASTLINK has an (undocumented) restriction that it is disabled if /PROFILE is selected. For GYP builds this feature is enabled with GYP_DEFINES=win_fastlink=1 For gn builds this feature is enabled with is_win_fastlink = true in args.gn. This switch is not supported on VC++ 2013 This connect bug requests a tool to de-fastlink a PDB so that it can be shared/deployed for debugging on other machines: https://connect.microsoft.com/VisualStudio/feedback/details/1598471 BUG=440500 R=jochen@chromium.org Committed: https://crrev.com/24a5806209d95faea058684b03a2d5f42c18ecae Cr-Commit-Position: refs/heads/master@{#340733}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
brucedawson
Can you take a look at this? This is my first non-trivial GN change so ...
2 years, 1 month ago (2015-07-27 21:16:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
2 years, 1 month ago (2015-07-28 14:41:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723012/1
2 years, 1 month ago (2015-07-28 17:24:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 1 month ago (2015-07-28 18:36:51 UTC) #6
commit-bot: I haz the power
2 years, 1 month ago (2015-07-28 18:37:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24a5806209d95faea058684b03a2d5f42c18ecae
Cr-Commit-Position: refs/heads/master@{#340733}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b