Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1254613003: Let the WebMediaPlayer decide whether to use overlay video. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trchen@'s comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 0c4b139119f85116b1d708a9974e1d892a242fe8..c57d5e881824708be42acf61f5ed5ce0c4423405 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -6558,37 +6558,6 @@ TEST_P(ParameterizedWebFrameTest, FullscreenSubframe)
EXPECT_EQ(viewportWidth, fullscreenLayoutObject->logicalHeight().toInt());
}
-TEST_F(WebFrameTest, FullscreenMediaStreamVideo)
Xianzhu 2015/08/03 22:39:02 Is the test case no longer applicable, or covered
Xianzhu 2015/08/03 22:40:07 Never mind. Saw your previous comment about this.
-{
- RuntimeEnabledFeatures::setOverlayFullscreenVideoEnabled(true);
- FakeCompositingWebViewClient client;
- registerMockedHttpURLLoad("fullscreen_video.html");
- FrameTestHelpers::WebViewHelper webViewHelper;
- WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(m_baseURL + "fullscreen_video.html", true, 0, &client, configureAndroid);
- int viewportWidth = 640;
- int viewportHeight = 480;
- client.m_screenInfo.rect.width = viewportWidth;
- client.m_screenInfo.rect.height = viewportHeight;
- webViewImpl->resize(WebSize(viewportWidth, viewportHeight));
- webViewImpl->layout();
-
- // Fake the video element as MediaStream
- RefPtrWillBeRawPtr<NullExecutionContext> context = adoptRefWillBeNoop(new NullExecutionContext());
- MediaStreamRegistry::registry().registerURL(0, toKURL(m_baseURL + "test.webm"), MediaStream::create(context.get()));
- Document* document = toWebLocalFrameImpl(webViewImpl->mainFrame())->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
- Element* videoFullscreen = document->getElementById("video");
- Fullscreen::from(*document).requestFullscreen(*videoFullscreen, Fullscreen::PrefixedRequest);
- webViewImpl->didEnterFullScreen();
- webViewImpl->layout();
-
- // Verify that the video layer is visible in fullscreen.
- DeprecatedPaintLayer* paintLayer = videoFullscreen->layoutObject()->enclosingLayer();
- GraphicsLayer* graphicsLayer = paintLayer->graphicsLayerBacking();
- EXPECT_TRUE(graphicsLayer->contentsAreVisible());
- context->notifyContextDestroyed();
-}
-
TEST_P(ParameterizedWebFrameTest, FullscreenWithTinyViewport)
{
FakeCompositingWebViewClient client;

Powered by Google App Engine
This is Rietveld 408576698