Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/web/FullscreenController.cpp

Issue 1254613003: Let the WebMediaPlayer decide whether to use overlay video. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trchen@'s comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/platform/RuntimeEnabledFeatures.in ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FullscreenController.cpp
diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp
index 482026645a5ce5d284a138d835d16dc59b0fd503..d651a8a53e33a56a9aba7a3b72bb0b6e80b93c50 100644
--- a/Source/web/FullscreenController.cpp
+++ b/Source/web/FullscreenController.cpp
@@ -85,11 +85,9 @@ void FullscreenController::didEnterFullScreen()
Fullscreen::from(document).didEnterFullScreenForElement(element.get());
ASSERT(Fullscreen::currentFullScreenElementFrom(document) == element);
- if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {
- if (isHTMLVideoElement(element)) {
- HTMLVideoElement* videoElement = toHTMLVideoElement(element);
- if (HTMLMediaElement::isMediaStreamURL(videoElement->sourceURL().string()))
- return;
+ if (isHTMLVideoElement(element)) {
+ HTMLVideoElement* videoElement = toHTMLVideoElement(element);
+ if (videoElement->useOverlayFullscreenVideo()) {
if (videoElement->webMediaPlayer()
// FIXME: There is no embedder-side handling in layout test mode.
&& !LayoutTestSupport::isRunningLayoutTest()) {
« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/platform/RuntimeEnabledFeatures.in ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698