Remove the Extensions URLRequestContext

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index fd32fe4fc7ab48a7f7eebe96dc63ebbe4b55ac8f..096dfb5fa4ab98604807b66e554ffda752f1253e 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -22,6 +22,7 @@
 #include "content/public/common/window_container_type.h"
 #include "net/base/mime_util.h"
 #include "net/cookies/canonical_cookie.h"
+#include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_job_factory.h"
 #include "third_party/WebKit/public/web/WebNotificationPresenter.h"
 #include "ui/base/window_open_disposition.h"
@@ -53,12 +54,12 @@ class ImageSkia;
 
 namespace net {
 class CookieOptions;
+class CookieStore;
 class HttpNetworkSession;
 class NetLog;
 class SSLCertRequestInfo;
 class SSLInfo;
 class URLRequest;
-class URLRequestContext;
 class URLRequestContextGetter;
 class X509Certificate;
 }
@@ -85,6 +86,7 @@ class BrowserMainParts;
 class BrowserPluginGuestDelegate;
 class BrowserPpapiHost;
 class BrowserURLHandler;
+class CookieStoreMap;
 class LocationProvider;
 class MediaObserver;
 class QuotaPermissionContext;
@@ -345,12 +347,13 @@ class CONTENT_EXPORT ContentBrowserClient {
       ResourceContext* context,
       const std::vector<std::pair<int, int> >& render_views);
 
-  // Allow the embedder to override the request context based on the URL for
-  // certain operations, like cookie access. Returns NULL to indicate the
-  // regular request context should be used.
-  // This is called on the IO thread.
-  virtual net::URLRequestContext* OverrideRequestContextForURL(
-      const GURL& url, ResourceContext* context);
+  // Allow the embedder to override the cookie store based on the scheme.

[jam, 2013/07/31 17:04:02]

nit: in general, ContentBrowserClient is the last-resort interface to use when
there's no other context. this seems like it should be a method on
BrowserContext

[awong, 2013/08/05 23:32:38]

I'm confused on this one. If we added into BrowserContext, all clients other
than Chrome will just have an empty implementation.  Further more, normal users
of BrowserContext would never want to call this API -- it only makes sense on
construction. Most of the existing BrowserContext APIs don't have these
properties.

If we added this to BrowserContext, I'd almost want to make this private in
addition to pure virtual...

+  virtual void OverrideCookieStoreMap(
+      BrowserContext* browser_context,
+      bool in_memory,
+      const base::FilePath& partition_path,
+      bool is_default,
+      CookieStoreMap* cookie_store_map) {}
 
   // Allow the embedder to specify a string version of the storage partition
   // config with a site.