Remove the Extensions URLRequestContext

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
 #include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/file_descriptor_info.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/socket_permission_request.h"
 #include "content/public/common/window_container_type.h"
 #include "net/base/mime_util.h"
 #include "net/cookies/canonical_cookie.h"
+#include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_job_factory.h"
 #include "third_party/WebKit/public/web/WebNotificationPresenter.h"
 #include "ui/base/window_open_disposition.h"
 #include "webkit/common/resource_type.h"
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 #include "base/posix/global_descriptors.h"
 #endif
 
 class CommandLine;
@@ skipping 11 matching lines @@
 namespace crypto {
 class CryptoModuleBlockingPasswordDelegate;
 }
 
 namespace gfx {
 class ImageSkia;
 }
 
 namespace net {
 class CookieOptions;
+class CookieStore;
 class HttpNetworkSession;
 class NetLog;
 class SSLCertRequestInfo;
 class SSLInfo;
 class URLRequest;
-class URLRequestContext;
 class URLRequestContextGetter;
 class X509Certificate;
 }
 
 namespace sandbox {
 class TargetPolicy;
 }
 
 namespace ui {
 class SelectFilePolicy;
 }
 
 namespace fileapi {
 class ExternalMountPoints;
 class FileSystemBackend;
 }
 
 namespace content {
 
 class AccessTokenStore;
 class BrowserChildProcessHost;
 class BrowserContext;
 class BrowserMainParts;
 class BrowserPluginGuestDelegate;
 class BrowserPpapiHost;
 class BrowserURLHandler;
+class CookieStoreMap;
 class LocationProvider;
 class MediaObserver;
 class QuotaPermissionContext;
 class RenderProcessHost;
 class RenderViewHost;
 class RenderViewHostDelegateView;
 class ResourceContext;
 class SiteInstance;
 class SpeechRecognitionManagerDelegate;
 class WebContents;
@@ skipping 240 matching lines @@
 
   // Allow the embedder to control if access to IndexedDB by a shared worker
   // is allowed.
   // This is called on the IO thread.
   virtual bool AllowWorkerIndexedDB(
       const GURL& url,
       const string16& name,
       ResourceContext* context,
       const std::vector<std::pair<int, int> >& render_views);
 
-  // Allow the embedder to override the request context based on the URL for
-  // certain operations, like cookie access. Returns NULL to indicate the
-  // regular request context should be used.
-  // This is called on the IO thread.
-  virtual net::URLRequestContext* OverrideRequestContextForURL(
-      const GURL& url, ResourceContext* context);
+  // Allow the embedder to override the cookie store based on the scheme.

[jam, 2013/07/31 17:04:02]

nit: in general, ContentBrowserClient is the last-resort interface to use when
there's no other context. this seems like it should be a method on
BrowserContext

[awong, 2013/08/05 23:32:38]

I'm confused on this one. If we added into BrowserContext, all clients other
than Chrome will just have an empty implementation.  Further more, normal users
of BrowserContext would never want to call this API -- it only makes sense on
construction. Most of the existing BrowserContext APIs don't have these
properties.

If we added this to BrowserContext, I'd almost want to make this private in
addition to pure virtual...

+  virtual void OverrideCookieStoreMap(
+      BrowserContext* browser_context,
+      bool in_memory,
+      const base::FilePath& partition_path,
+      bool is_default,
+      CookieStoreMap* cookie_store_map) {}
 
   // Allow the embedder to specify a string version of the storage partition
   // config with a site.
   virtual std::string GetStoragePartitionIdForSite(
       content::BrowserContext* browser_context,
       const GURL& site);
 
   // Allows the embedder to provide a validation check for |partition_id|s.
   // This domain of valid entries should match the range of outputs for
   // GetStoragePartitionIdForChildProcess().
@@ skipping 244 matching lines @@
   // This is called on a worker thread.
   virtual
       crypto::CryptoModuleBlockingPasswordDelegate* GetCryptoPasswordDelegate(
           const GURL& url);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_