Chromium Code Reviews| Index: chrome/browser/ui/browser_instant_controller.cc |
| =================================================================== |
| --- chrome/browser/ui/browser_instant_controller.cc (revision 186976) |
| +++ chrome/browser/ui/browser_instant_controller.cc (working copy) |
| @@ -107,7 +107,6 @@ |
| // inserting instant_ntp into the tabstrip and will take ownership. |
| ignore_result(instant_ntp.release()); |
| } |
| - content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP")); |
| return true; |
| } |
| @@ -239,6 +238,13 @@ |
| void BrowserInstantController::ModeChanged(const search::Mode& old_mode, |
| const search::Mode& new_mode) { |
| + if (search::IsInstantExtendedAPIEnabled()) { |
| + if (new_mode.is_search_results()) |
| + content::RecordAction(UserMetricsAction("InstantExtended.ShowSRP")); |
| + else if (new_mode.is_ntp()) |
| + content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP")); |
|
samarth
2013/03/08 22:44:18
Sorry, I tried to follow Sreeram and your discussi
samarth
2013/03/08 22:48:11
OK, Sreeram pointed me to the internal thread that
Alexei Svitkine (slow)
2013/03/11 15:13:42
Comment added.
|
| + } |
| + |
| // If mode is now |NTP|, send theme-related information to Instant. |
| if (new_mode.is_ntp()) |
| UpdateThemeInfo(); |