Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 12546011: Add UMA action InstantExtended.ShowSRP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/chromeactions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_instant_controller.cc
===================================================================
--- chrome/browser/ui/browser_instant_controller.cc (revision 186976)
+++ chrome/browser/ui/browser_instant_controller.cc (working copy)
@@ -107,7 +107,6 @@
// inserting instant_ntp into the tabstrip and will take ownership.
ignore_result(instant_ntp.release());
}
- content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP"));
return true;
}
@@ -239,6 +238,13 @@
void BrowserInstantController::ModeChanged(const search::Mode& old_mode,
const search::Mode& new_mode) {
+ if (search::IsInstantExtendedAPIEnabled()) {
+ if (new_mode.is_search_results())
+ content::RecordAction(UserMetricsAction("InstantExtended.ShowSRP"));
+ else if (new_mode.is_ntp())
+ content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP"));
samarth 2013/03/08 22:44:18 Sorry, I tried to follow Sreeram and your discussi
samarth 2013/03/08 22:48:11 OK, Sreeram pointed me to the internal thread that
Alexei Svitkine (slow) 2013/03/11 15:13:42 Comment added.
+ }
+
// If mode is now |NTP|, send theme-related information to Instant.
if (new_mode.is_ntp())
UpdateThemeInfo();
« no previous file with comments | « no previous file | chrome/tools/chromeactions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698