Add UMA action InstantExtended.ShowSRP.

chrome/browser/ui/browser_instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_instant_controller.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/instant/search.h"
@@ skipping 89 matching lines @@
         &source_contents->GetController());
     ReplaceWebContentsAt(
         browser_->tab_strip_model()->GetIndexOfWebContents(source_contents),
         instant_ntp.Pass());
   } else {
     instant_ntp->GetController().PruneAllButActive();
     // If |source_contents| is NULL, then the caller is responsible for
     // inserting instant_ntp into the tabstrip and will take ownership.
     ignore_result(instant_ntp.release());
   }
-  content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP"));
   return true;
 }
 
 bool BrowserInstantController::OpenInstant(WindowOpenDisposition disposition) {
   // Unsupported dispositions.
   if (disposition == NEW_BACKGROUND_TAB || disposition == NEW_WINDOW)
     return false;
 
   // The omnibox currently doesn't use other dispositions, so we don't attempt
   // to handle them. If you hit this DCHECK file a bug and I'll (sky) add
@@ skipping 111 matching lines @@
       (!instant_pref_enabled &&
        !profile()->GetPrefs()->GetBoolean(prefs::kSearchSuggestEnabled));
   instant_.SetInstantEnabled(instant_pref_enabled, use_local_overlay_only);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserInstantController, search::SearchModelObserver implementation:
 
 void BrowserInstantController::ModeChanged(const search::Mode& old_mode,
                                            const search::Mode& new_mode) {
+  if (search::IsInstantExtendedAPIEnabled()) {
+    if (new_mode.is_search_results())
+      content::RecordAction(UserMetricsAction("InstantExtended.ShowSRP"));
+    else if (new_mode.is_ntp())
+      content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP"));

[samarth, 2013/03/08 22:44:18]

Sorry, I tried to follow Sreeram and your discussion and this still doesn't make
sense to me.  So if you switch away from an NTP tab and then switch back, this
will fire a second ShowNTP.  That doesn't seem right to me.

[samarth, 2013/03/08 22:48:11]

OK, Sreeram pointed me to the internal thread that explains why this makes
sense.  It's probably worth adding a comment for why we log this way since it
really isn't obvious otherwise.

[Alexei Svitkine (slow), 2013/03/11 15:13:42]

Comment added.

+  }
+
   // If mode is now |NTP|, send theme-related information to Instant.
   if (new_mode.is_ntp())
     UpdateThemeInfo();
 
   instant_.SearchModeChanged(old_mode, new_mode);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserInstantController, content::NotificationObserver implementation:
 
@@ skipping 75 matching lines @@
     initialized_theme_info_ = true;
   }
 
   DCHECK(initialized_theme_info_);
 
   if (browser_->search_model()->mode().is_ntp())
     instant_.ThemeChanged(theme_info_);
 }
 
 }  // namespace chrome