net/quic/quic_stream_factory.cc - Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.cc

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test leak Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_stream_factory.cc

diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc

index c5a5026a6d42e035094ce3bde18e2ba46cf8dcb0..1cb3ff367b805e83c36999e53d6a3668e2ef3efd 100644

--- a/net/quic/quic_stream_factory.cc

+++ b/net/quic/quic_stream_factory.cc

@@ -374,8 +374,8 @@ QuicClientSession* QuicStreamFactory::CreateSession(

clock_.get(), random_generator_, socket);

QuicConnection* connection = new QuicConnection(guid, addr, helper, false);

- QuicClientSession* session = new QuicClientSession(connection, helper, this,

- host, net_log.net_log());

+ QuicClientSession* session =

+ new QuicClientSession(connection, socket, this, host, net_log.net_log());

all_sessions_.insert(session); // owning pointer

return session;

}

« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »