net/quic/quic_http_stream_test.cc - Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_stream_test.cc

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test leak Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_http_stream_test.cc

diff --git a/net/quic/quic_http_stream_test.cc b/net/quic/quic_http_stream_test.cc

index 4f5aa1c10952598d14ef6cd7c95b60e19febb7b1..8751efde0a3ac36440f39482f3923a38fa46eb8a 100644

--- a/net/quic/quic_http_stream_test.cc

+++ b/net/quic/quic_http_stream_test.cc

@@ -177,7 +177,7 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {

connection_->set_visitor(&visitor_);

connection_->SetSendAlgorithm(send_algorithm_);

connection_->SetReceiveAlgorithm(receive_algorithm_);

- session_.reset(new QuicClientSession(connection_, helper_, NULL,

+ session_.reset(new QuicClientSession(connection_, socket, NULL,

"www.google.com", NULL));

scoped_ptr<QuicPacket> shlo(ConstructServerHelloPacket(

guid_, &clock_, &random_generator_, "www.google.com"));

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »