Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: net/quic/quic_connection_test.cc

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_helper_test.cc ('k') | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index d55850b62f05878495024945a9873fd266966b24..fc7b3e29864b43bb7a08fa6ce59f0a3922bdadfa 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -226,7 +226,7 @@ class QuicConnectionTest : public ::testing::Test {
creator_(guid_, &framer_, QuicRandom::GetInstance()),
send_algorithm_(new StrictMock<MockSendAlgorithm>),
helper_(new TestConnectionHelper(&clock_, &random_generator_)),
- connection_(guid_, IPEndPoint(), helper_.get()),
+ connection_(guid_, IPEndPoint(), helper_),
frame1_(1, false, 0, data1),
frame2_(1, false, 3, data2),
accept_packet_(true) {
@@ -447,7 +447,7 @@ class QuicConnectionTest : public ::testing::Test {
TestReceiveAlgorithm* receive_algorithm_;
MockClock clock_;
MockRandom random_generator_;
- scoped_ptr<TestConnectionHelper> helper_;
+ TestConnectionHelper* helper_; // owned by connection_
ramant (doing other things) 2013/03/14 17:08:04 overly nit: Consider capitalizing owned. owned ->
TestConnection connection_;
testing::StrictMock<MockConnectionVisitor> visitor_;
« no previous file with comments | « net/quic/quic_connection_helper_test.cc ('k') | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698