Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: net/quic/quic_connection_helper_test.cc

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_helper_test.cc
diff --git a/net/quic/quic_connection_helper_test.cc b/net/quic/quic_connection_helper_test.cc
index 544dec45636ab06e258bf710067faa69956c0fc5..f2d332383f84ead665c309709bf880887f1a6fb2 100644
--- a/net/quic/quic_connection_helper_test.cc
+++ b/net/quic/quic_connection_helper_test.cc
@@ -104,12 +104,12 @@ class QuicConnectionHelperTest : public ::testing::Test {
new MockUDPClientSocket(socket_data_.get(), net_log_.net_log());
socket->Connect(IPEndPoint());
runner_ = new TestTaskRunner(&clock_);
- helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_,
- &random_generator_, socket));
+ helper_ = new QuicConnectionHelper(runner_.get(), &clock_,
+ &random_generator_, socket);
send_algorithm_ = new testing::StrictMock<MockSendAlgorithm>();
EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _)).
WillRepeatedly(testing::Return(QuicTime::Delta::Zero()));
- connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_.get()));
+ connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_));
connection_->set_visitor(&visitor_);
connection_->SetSendAlgorithm(send_algorithm_);
}
@@ -173,7 +173,7 @@ class QuicConnectionHelperTest : public ::testing::Test {
testing::StrictMock<MockSendAlgorithm>* send_algorithm_;
scoped_refptr<TestTaskRunner> runner_;
- scoped_ptr<QuicConnectionHelper> helper_;
+ QuicConnectionHelper* helper_;
scoped_array<MockWrite> mock_writes_;
MockClock clock_;
MockRandom random_generator_;

Powered by Google App Engine
This is Rietveld 408576698