Issue 12545010: Revert 186522

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12545010: Revert 186522 (Closed)

Created:
7 years, 9 months ago by miu

Modified:
7 years, 9 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 186522 > Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall. > > remoting_host_installation uses lots of non-trivial GYP that tend to break because of differences between ninja and msbuild. Building it on the main waterfall gives us an early warning if something goes wrong. > > BUG=180600 > > Review URL: https://codereview.chromium.org/12543006 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186526

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -33 lines)			Patch
	M	build/all.gyp	View		1 chunk	+19 lines, -28 lines	0 comments	Download
	M	remoting/remoting.gyp	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r186526.

Expand Messages | Collapse Messages