Issue 1254423007: Revert of Ensure that title and state updating works without page id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1254423007: Revert of Ensure that title and state updating works without page id. (Closed)

Created:
5 years, 4 months ago by Avi (use Gerrit)

Modified:
5 years, 4 months ago

Reviewers:
nasko

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Ensure that title and state updating works without page id. (patchset #1 id:1 of https://codereview.chromium.org/1259213003/) Reason for revert: Title updating isn't working; revert for now. Original issue's description: > Ensure that title and state updating works without page id. > > BUG=369661 > TEST=everything stays green > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/4a1c1980e95fe8cd36f7b2910757ace3b8970aa0 > Cr-Commit-Position: refs/heads/master@{#340960} TBR=nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/1ebdbc4ce75bf03e885ce4ed733bcae0704d5bfe Cr-Commit-Position: refs/heads/master@{#341188}

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Created Revert of Ensure that title and state updating works without page id.

5 years, 4 months ago (2015-07-30 20:40:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254423007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254423007/1

5 years, 4 months ago (2015-07-30 20:41:44 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-30 20:43:58 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1ebdbc4ce75bf03e885ce4ed733bcae0704d5bfe
Cr-Commit-Position: refs/heads/master@{#341188}

Expand Messages | Collapse Messages