Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: components/view_manager/view_manager_client_apptest.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/view_manager_client_apptest.cc
diff --git a/components/view_manager/view_manager_client_apptest.cc b/components/view_manager/view_manager_client_apptest.cc
index 960625e0370f6aa4b11c1592dc6127d0f541ea93..0d5f4e0c5e49653dd76130c96e46dd8fce33521a 100644
--- a/components/view_manager/view_manager_client_apptest.cc
+++ b/components/view_manager/view_manager_client_apptest.cc
@@ -184,7 +184,7 @@ class ViewManagerTest : public ViewManagerTestBase {
void ConnectToApplicationAndEmbed(View* view) {
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From(application_impl()->url());
- ApplicationConnection* connection =
+ scoped_ptr<ApplicationConnection> connection =
application_impl()->ConnectToApplication(request.Pass());
mojo::ViewManagerClientPtr client;
connection->ConnectToService(&client);
@@ -197,7 +197,7 @@ class ViewManagerTest : public ViewManagerTestBase {
mojo::ViewManagerClientPtr* client) override {
on_will_embed_count_++;
if (on_will_embed_return_value_) {
- ApplicationConnection* connection =
+ scoped_ptr<ApplicationConnection> connection =
application_impl()->ConnectToApplication(request.Pass());
connection->ConnectToService(client);
} else {
« no previous file with comments | « components/view_manager/public/cpp/view_manager_init.h ('k') | components/view_manager/view_manager_service_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698