components/view_manager/public/cpp/view_manager_init.h - Issue 1254383016: ApplicationConnection lifetime management changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/public/cpp/view_manager_init.h

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/public/cpp/view_manager_init.h

diff --git a/components/view_manager/public/cpp/view_manager_init.h b/components/view_manager/public/cpp/view_manager_init.h

index 3d5129de75548d36bca464313a1ff58600df3c4a..347eb942cc240c790dfed3d35e9f2138c0ff3262 100644

--- a/components/view_manager/public/cpp/view_manager_init.h

+++ b/components/view_manager/public/cpp/view_manager_init.h

@@ -33,7 +33,7 @@ class ViewManagerInit {

ViewManagerRoot* view_manager_root() { return view_manager_root_.get(); }

// Returns the application connection established with the view manager.

- ApplicationConnection* connection() { return connection_; }

+ ApplicationConnection* connection() { return connection_.get(); }

private:

class ClientFactory;

@@ -41,7 +41,7 @@ class ViewManagerInit {

void OnCreate(InterfaceRequest<ViewManagerClient> request);

ApplicationImpl* app_;

- ApplicationConnection* connection_;

+ scoped_ptr<ApplicationConnection> connection_;

ViewManagerDelegate* delegate_;

scoped_ptr<ClientFactory> client_factory_;

ViewManagerRootPtr view_manager_root_;