Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: mojo/shell/application_manager_unittest.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/application_manager_unittest.cc
diff --git a/mojo/shell/application_manager_unittest.cc b/mojo/shell/application_manager_unittest.cc
index 01c285cf656c6f3695fdd26bcf537604a983a5cf..e4bfb3759589ac91ae0c6fc14aeb410e341bf8f9 100644
--- a/mojo/shell/application_manager_unittest.cc
+++ b/mojo/shell/application_manager_unittest.cc
@@ -274,7 +274,8 @@ class TestAImpl : public TestA {
: test_context_(test_context), binding_(this, request.Pass()) {
mojo::URLRequestPtr request2(mojo::URLRequest::New());
request2->url = mojo::String::From(kTestBURLString);
- app_impl->ConnectToApplication(request2.Pass())->ConnectToService(&b_);
+ connection_ = app_impl->ConnectToApplication(request2.Pass());
+ connection_->ConnectToService(&b_);
}
~TestAImpl() override {
@@ -298,6 +299,7 @@ class TestAImpl : public TestA {
test_context_->QuitSoon();
}
+ scoped_ptr<ApplicationConnection> connection_;
TesterContext* test_context_;
TestBPtr b_;
StrongBinding<TestA> binding_;

Powered by Google App Engine
This is Rietveld 408576698