Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/common/tracing_impl.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/application/public/cpp/tests/service_registry_unittest.cc ('K') | « mojo/application/public/cpp/tests/service_registry_unittest.cc ('k') | mojo/mojo_base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/tracing_impl.cc
diff --git a/mojo/common/tracing_impl.cc b/mojo/common/tracing_impl.cc
index a8d2f3608f48b16b2e6583d8510a0627a46e1e6d..ef4bcdf2c94486cb96621047ebf099371dcaaaed 100644
--- a/mojo/common/tracing_impl.cc
+++ b/mojo/common/tracing_impl.cc
@@ -20,7 +20,8 @@ TracingImpl::~TracingImpl() {
void TracingImpl::Initialize(ApplicationImpl* app) {
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:tracing");
- ApplicationConnection* connection = app->ConnectToApplication(request.Pass());
+ scoped_ptr<ApplicationConnection> connection =
sky 2015/08/11 18:28:04 Don't you need to persist this connection, else th
+ app->ConnectToApplication(request.Pass());
connection->AddService(this);
}
« mojo/application/public/cpp/tests/service_registry_unittest.cc ('K') | « mojo/application/public/cpp/tests/service_registry_unittest.cc ('k') | mojo/mojo_base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698