mojo/services/network/http_server_apptest.cc - Issue 1254383016: ApplicationConnection lifetime management changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/network/http_server_apptest.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/network/http_server_apptest.cc

diff --git a/mojo/services/network/http_server_apptest.cc b/mojo/services/network/http_server_apptest.cc

index 32c249c32bd1bce396c4cc73bc586d886bb91e91..dfe5deee77ef85fbb0cd8cce9ef09a0ec7ff1fb6 100644

--- a/mojo/services/network/http_server_apptest.cc

+++ b/mojo/services/network/http_server_apptest.cc

@@ -553,7 +553,7 @@ class HttpServerAppTest : public test::ApplicationTestBase {

mojo::URLRequestPtr request(mojo::URLRequest::New());

request->url = mojo::String::From("mojo:network_service");

- ApplicationConnection* connection =

+ scoped_ptr<ApplicationConnection> connection =

application_impl()->ConnectToApplication(request.Pass());

connection->ConnectToService(&network_service_);

}