Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254383002: Remove GLContext::Destroy (Closed)

Created:
5 years, 4 months ago by piman
Modified:
5 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GLContext::Destroy It should not be called explicitly. Make overrides private. Committed: https://crrev.com/74a0f5aebe43e45741db974c9623f2cdba89565e Cr-Commit-Position: refs/heads/master@{#340601}

Patch Set 1 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M gpu/command_buffer/service/gl_context_virtual.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_api_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_context.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_context_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/gl/gl_context_egl.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_context_glx.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_context_osmesa.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_context_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_context_stub.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_context_wgl.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
piman
5 years, 4 months ago (2015-07-27 22:41:22 UTC) #5
no sievers
lgtm
5 years, 4 months ago (2015-07-27 22:48:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254383002/60001
5 years, 4 months ago (2015-07-27 23:09:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 4 months ago (2015-07-27 23:40:49 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 23:41:44 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/74a0f5aebe43e45741db974c9623f2cdba89565e
Cr-Commit-Position: refs/heads/master@{#340601}

Powered by Google App Engine
This is Rietveld 408576698